Skip to content

Upgrade Leeway to 0.10.2 #20764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

Upgrade Leeway to 0.10.2 #20764

merged 1 commit into from
Apr 28, 2025

Conversation

corneliusludmann
Copy link
Contributor

@corneliusludmann corneliusludmann commented Apr 22, 2025 •
edited
Loading

Description

Upgrade the version of Leeway to 0.10.2.

This also needs to change how supervisor openssh is built since the way docker builds are handles in Leeway have been changed.

Related Issue(s)

Fixes https://linear.app/gitpod/issue/CLC-1291

How to test

https://github.com/gitpod-io/gitpod/actions/runs/14616026521

https://clu-upgrade-leeway.preview.gitpod-dev.com/

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@corneliusludmann corneliusludmann force-pushed the clu/upgrade-leeway branch 3 times, most recently from b846861 to a949a0b Compare April 23, 2025 10:34
@corneliusludmann corneliusludmann changed the title Upgrade Leeway to 0.10.1 Upgrade Leeway to 0.10.2 Apr 23, 2025
@corneliusludmann corneliusludmann force-pushed the clu/upgrade-leeway branch 3 times, most recently from b859eeb to cf6b0ab Compare April 25, 2025 11:08
@corneliusludmann corneliusludmann marked this pull request as ready for review April 25, 2025 11:27
@corneliusludmann corneliusludmann requested review from a team as code owners April 25, 2025 11:27
@geropl
Copy link
Member

geropl commented Apr 25, 2025

@corneliusludmann Can we hold of merging for today please? Planning shipping a fix.

@corneliusludmann
Copy link
Contributor Author

There is currently an issue with building ide/code due to the open-vsx.org outage (cf. https://linear.app/gitpod/issue/CLC-1291/upgrade-leeway-in-gitpodgitpod-io-and-gitpodgitpod-dedicated-repos#comment-66a1f862).

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

@corneliusludmann
Copy link
Contributor Author

There is currently an issue with building ide/code due to the open-vsx.org outage (cf. https://linear.app/gitpod/issue/CLC-1291/upgrade-leeway-in-gitpodgitpod-io-and-gitpodgitpod-dedicated-repos#comment-66a1f862).

Build is fully green again. 🥳

@roboquat roboquat added size/S and removed size/M labels Apr 25, 2025
@geropl
Copy link
Member

geropl commented Apr 28, 2025

Build is red again with this, let me see if I can fix it:
image

@corneliusludmann
Copy link
Contributor Author

Build is red again with this, let me see if I can fix it

Damn it. I see the problem. When the docker build of components/supervisor/openssh:docker-build uses cached layers, the content/ folder does not exist. I can recreate it in a workspace. After running docker system prune --all the leeway build works again. 😠 😡

We need to figure out how to get the content with cached Docker layers.

@geropl
Copy link
Member

geropl commented Apr 28, 2025 •
edited
Loading

@corneliusludmann Is it that? Or is it because if now uses the old leeway version to build the PR, still? 🤔

As a side-effect of splitting the PR in two? I think the change belongs into the 2nd PR as well 👍

@corneliusludmann
Copy link
Contributor Author

Is it that? Or is it because if now uses the old leeway version to build the PR, still? 🤔

Maybe you're right.

As a side-effect of splitting the PR in two? I think the change belongs into the 2nd PR as well 👍

Makes sense.

Let's try it.

@roboquat roboquat added size/XS and removed size/S labels Apr 28, 2025
geropl
geropl approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@geropl
Copy link
Member

geropl commented Apr 28, 2025

/unhold

@roboquat roboquat merged commit 189cafb into main Apr 28, 2025
18 checks passed
@roboquat roboquat deleted the clu/upgrade-leeway branch April 28, 2025 12:01
@corneliusludmann corneliusludmann mentioned this pull request Apr 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iQQBot iQQBot iQQBot left review comments

@geropl geropl geropl approved these changes

Assignees
No one assigned
Labels
size/XS team: team-engine team: team-enterprise team: team-experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@corneliusludmann @geropl @iQQBot @roboquat